Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix make watch for generated files #20794

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Aug 14, 2022

  • Don't rebuild the binary when generated files are updated, which is the case by-default when running make watch.

- Don't rebuild the binary when generated files are updated, which is the
case by-default when running `make watch`.
@Gusted Gusted added this to the 1.18.0 milestone Aug 14, 2022
@Gusted Gusted added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 14, 2022
@Gusted Gusted removed this from the 1.18.0 milestone Aug 14, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 14, 2022
@techknowlogick techknowlogick added this to the 1.18.0 milestone Aug 14, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 14, 2022
@zeripath zeripath merged commit 2935445 into go-gitea:main Aug 14, 2022
@Gusted Gusted deleted the fix-make-watch branch August 14, 2022 21:22
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 15, 2022
* giteaofficial/main:
  Remove follow from commits by file (go-gitea#20765)
  [skip ci] Updated translations via Crowdin
  Fix `make watch` for generated files (go-gitea#20794)
  Add missing translation for queue flush workers (go-gitea#20791)
  Update zh-cn translation for Installation from source (go-gitea#20772)
  Improve comment header for Mobile (go-gitea#20781)
  Add myself to MAINTAINERS (go-gitea#20786)
  [skip ci] Updated licenses and gitignores
  Preserve unix socket file (go-gitea#20499)
  Switch Unicode Escaping to a VSCode-like system (go-gitea#19990)
  Fix git.Init for doctor sub-command (go-gitea#20782)
  Remove the translation key website by PR go-gitea#20777 (go-gitea#20779)
  Move the official website link at the footer of gitea (go-gitea#20777)
  Remove useless JS operation for relative time tooltips (go-gitea#20756)
  Remove debug output when coverage fails (go-gitea#20733)
  Slightly reduce exclamation icon size (go-gitea#20753)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 28, 2022
- Don't rebuild the binary when generated files are updated, which is the
case by-default when running `make watch`.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants